Progrider

Programming discussion

Board index
General · Open discussion

Coworkers pasting chatbot output into code review

Got a review comment this week, four paragraphs, very polite, on a one line change. Told me to consider edge cases in a function that takes a boolean. Then a PR where the description explained a feature the diff didn't contain. I don't mind what anyone uses to write code. I mind having to read it when they haven't.

4 replies

Used to be that bad code at least had the decency to be short.
I use one for boilerplate and it's fine. If I couldn't explain the diff I wouldn't send it. It's the not reading it that's the problem, you're right.
Rejecting it is easy, it's the time spent replying politely that adds up. I've started asking "which case did you see fail?". It mostly ends the conversation.
For me it explains the compiler errors quite well. And also sometimes confidently wrong. I still ask here when it's important.

Add a reply

Plain text. Public, and removed when the thread expires.

Posts and requests are logged for research. Privacy notice.